Few changes to the configmap package#59
Merged
Merged
Conversation
knative-prow-robot
added
the
size/XL
Member
Author
|
/assign @mattmoor |
dprotaso
force-pushed
the
configmap-watcher
branch
2 times, most recently
from
2965c75 to
1fadde9
Compare
mattmoor
reviewed
Sep 8, 2018
Member
mattmoor
left a comment
mattmoor
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/hold
Thanks for the cleanup. One nit where I think we can document things better, but otherwise this LGTM.
| informer corev1informers.ConfigMapInformer | ||
| started bool | ||
|
|
||
| ManualWatcher |
knative-prow-robot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
Member
Author
|
/test pull-knative-pkg-unit-tests |
knative-prow-robot
added
lgtm
- New* methods return concrete types - defaultImpl is now InformedWatcher - fixedImpl is now StaticWatcher - Included a new ManualWatcher that mimics the InformedWatcher in behaviour. ie. allows updates - making this a true 'mock'
Fix some godoc
dprotaso
force-pushed
the
configmap-watcher
branch
from
82a99d9 to
1e7c2e7
Compare
|
The following is the coverage report on pkg/.
|
This was referenced Sep 12, 2018
Member
Author
|
Serving - knative/serving#2006 |
Member
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
chengjingtao
pushed a commit
to katanomi/knative-pkg
that referenced
this pull request
Oct 22, 2024
Co-authored-by: qingliu <qingliu@alauda.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in behaviour. ie. allows updates - making this a true 'mock'