Skip to content

Eventing Stackdriver integration#612

Merged
knative-prow-robot merged 4 commits into
knative:masterfrom
nachocano:stackdriver
Aug 30, 2019
Merged

Eventing Stackdriver integration#612
knative-prow-robot merged 4 commits into
knative:masterfrom
nachocano:stackdriver

Conversation

@nachocano
Copy link
Copy Markdown
Contributor

@nachocano nachocano commented Aug 28, 2019 •
edited
Loading

Helps with knative/eventing#1693

  • Adding eventing metrics for integrating with Stackdriver.
  • Currently, the Stackdriver exporter is tightly coupled with serving metrics. In order to iterate fast, we add here the eventing metrics as well.
  • A future refactor needs to take place to move specific serving and eventing pieces out of pkg. Issue #608 was filed to track those changes. It is a bigger change as it will probably involve changing the signature in UpdateExporterFromConfigMap, which is widely used throughout the code.
  • Minor changes for splitting serving and eventing pieces were done in this PR, which will make the future one easier. Note files *_eventing or *_serving, which can be moved as is (and renamed).

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 28, 2019
@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 28, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 28, 2019

/assign @yanweiguo

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 28, 2019

/assing @mdemirhan

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 28, 2019

/assign @Harwayne

yanweiguo
yanweiguo reviewed Aug 28, 2019
View reviewed changes
Comment thread metrics/metricskey/constants.go Outdated
Comment thread metrics/monitored_resources.go Outdated
Comment thread metrics/monitored_resources.go
Comment thread metrics/metricskey/constants_eventing.go
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 29, 2019

@yanweiguo let me know if you agree with the comments above, thanks!

@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Aug 29, 2019

The following is the coverage report on pkg/.
Say /test pull-knative-pkg-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
metrics/monitored_resources_eventing.go Do not exist 100.0%
metrics/monitored_resources_serving.go Do not exist 100.0%
metrics/record.go 71.4% 75.0% 3.6
metrics/stackdriver_exporter.go 94.4% 93.3% -1.1

@yanweiguo
Copy link
Copy Markdown
Contributor

yanweiguo commented Aug 29, 2019

/lgtm
Please verify that it won't break metrics reporting to Stackdriver in serving.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2019
@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 29, 2019

/lgtm
Please verify that it won't break metrics reporting to Stackdriver in serving.

Will do, do you know if there are e2e for metrics in serving?

@nachocano
Copy link
Copy Markdown
Contributor Author

nachocano commented Aug 29, 2019

seems to be a problem with the cluster creation...

/test pull-knative-pkg-unit-tests

@yanweiguo
Copy link
Copy Markdown
Contributor

yanweiguo commented Aug 29, 2019

/lgtm
Please verify that it won't break metrics reporting to Stackdriver in serving.

Will do, do you know if there are e2e for metrics in serving?

I don't think so.

@vaikas
Copy link
Copy Markdown
Contributor

vaikas commented Aug 30, 2019

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nachocano, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2019
@knative-prow-robot knative-prow-robot merged commit ec2f20a into knative:master Aug 30, 2019
@nachocano nachocano mentioned this pull request Aug 30, 2019
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

1 more reviewer

@yanweiguo yanweiguo yanweiguo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Harwayne Harwayne

@vaikas vaikas

@yanweiguo yanweiguo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nachocano @knative-metrics-robot @yanweiguo @vaikas @knative-prow-robot @Harwayne @googlebot