Skip to content

Update test README.md#966

Merged
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:master
Dec 27, 2019
Merged

Update test README.md#966
knative-prow-robot merged 1 commit intoknative:masterfrom
MIBc:master

Conversation

@MIBc
Copy link
Copy Markdown
Contributor

@MIBc MIBc commented Dec 27, 2019

Add flags and their explaination.

Add flags and its explaination.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 27, 2019
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 27, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coryrc
Copy link
Copy Markdown
Contributor

coryrc commented Dec 27, 2019

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 27, 2019
Copy link
Copy Markdown
Contributor

@coryrc coryrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@coryrc
Copy link
Copy Markdown
Contributor

coryrc commented Dec 27, 2019

Unfortunately it will take a week or so for the holidays to be over and someone to approve it for merging. Sorry I can't!

/assign @adrcunha

@MIBc
Copy link
Copy Markdown
Contributor Author

MIBc commented Dec 27, 2019

That's ok. Thanks

@adrcunha
Copy link
Copy Markdown
Contributor

/approve
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2019
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, coryrc, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 27, 2019
@knative-prow-robot knative-prow-robot merged commit 00c3fda into knative:master Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants