Skip to content

add docs release process#10

Closed
csantanapr wants to merge 1 commit into
knative:mainfrom
csantanapr:add-docs
Closed

add docs release process#10
csantanapr wants to merge 1 commit into
knative:mainfrom
csantanapr:add-docs

Conversation

@csantanapr
Copy link
Copy Markdown
Member

Add docs info for the folks cutting the knative release to also cut the docs/spec for the website.

Related to knative/community#429

Signed-off-by: Carlos Santana <csantana23@gmail.com>
@csantanapr csantanapr requested review from a team as code owners May 5, 2021 18:46
@csantanapr csantanapr requested a review from a team May 5, 2021 18:46
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 5, 2021
@knative-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csantanapr
Copy link
Copy Markdown
Member Author

/assign @vaikas

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2021
@csantanapr
Copy link
Copy Markdown
Member Author

/assign @tcnghia

Comment thread README.md
Send a PR like [this one](https://github.com/knative-sandbox/knobots/pull/18) to
bump knobots auto release workflow to the next release.

## Release docs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the release leads supposed to perform the documentation release after all other repos have been released ?

How it is ensured that the release leads have the proper permissions for doing this ? (i.e. who is contacting @carieshmarie or @RichieEscarez for setting the SSH keys for Netlify and GitHub ?)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Roland,

A1: Yes, wait for /Serving and /Eventing (see steps below).

A2: You dont necessarily need elevated permissions or special SSH keys but having Approval privileges for the /Docs and /Website repos helps ease the process (just requires the "releaser" to get an LGTM).

Today, Netlify and GitHub just work. You dont need to touch Netlify, the knative.dev builds automatically run, pickup, and show whatever is merged in GitHub (from both /docs and /website repos). I was able to hand off the process to both @csantanapr and @omerbensaadon (who "released" the last two versions).

General steps

As a minimum example, here are the two PRs from the last release, that you can use to "cut and publish a new release":

  1. Wait for dependent repos to release (today thats /serving and /eventing), then generate the new API docs and merge them before creating a new branch: Releasing v0.22.0 docs#3426
  2. Create the new /docs branch: https://knative.dev/help/maintainer/docs-release-process/#create-branch-from-updated-main
  3. Add the new /docs branch to the website builds: Releasing 0.22 website#287

With that said, the user experience team is completely changing the Docs build and publishing process but they are defining/driving that effort and can help you understand whats changed (ie the new steps to cut a release).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a step #4:

  1. Sync the knative/website staging branch to include all the same commits as main: Update the Staging branch website#297

@evankanderson
Copy link
Copy Markdown
Member

/assign @shinigambit @evankanderson

This looks like an opportunity to do some paired review with Fabian, will look at this later today or maybe tomorrow.

@evankanderson
Copy link
Copy Markdown
Member

Hi Carlos,

I think we should move "Release docs" up next to "Release a repository" (maybe at the bottom of that section), and add a note near the top of "release a repository" that docs follows a special process.

We should probably also update the timeline to indicate that Docs follows a special process, but that it doesn't need to be skipped -- right now it's in a "skip these" block.

@csantanapr csantanapr mentioned this pull request May 19, 2021
@csantanapr
Copy link
Copy Markdown
Member Author

replaced by #19

@csantanapr csantanapr closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants