Remove all the arguments for controller#294
Conversation
knative-prow-robot
left a comment
There was a problem hiding this comment.
@houshengbo: 0 warnings.
Details
In response to this:
Fixes #
Proposed Changes
Release Note
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is a duplicate of #293, I think? Also: Should we really drop the master/kubeconfig options for manifestival usage? I feel like that'll cause weird behavior if somebody is using that and it's not consistently used between the "normal" clients and manifestival's. /hold For waiting for #293 to merge first. |
Proposed Changes
Release Note