Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Remove all the arguments for controller#294

Closed
houshengbo wants to merge 1 commit into
knative:masterfrom
houshengbo:replace-config
Closed

Remove all the arguments for controller#294
houshengbo wants to merge 1 commit into
knative:masterfrom
houshengbo:replace-config

Conversation

@houshengbo
Copy link
Copy Markdown

@houshengbo houshengbo commented Feb 12, 2020

Proposed Changes

  • We will leverage sharedmain to get the configuration we need for operator use.

Release Note


@googlebot googlebot added the cla: yes Author(s) signed a CLA. label Feb 12, 2020
Copy link
Copy Markdown
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houshengbo: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markusthoemmes
Copy link
Copy Markdown
Contributor

This is a duplicate of #293, I think? Also: Should we really drop the master/kubeconfig options for manifestival usage? I feel like that'll cause weird behavior if somebody is using that and it's not consistently used between the "normal" clients and manifestival's.

/hold

For waiting for #293 to merge first.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants