Remove the deprecated short name from README#346
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Welcome @q0115643! It looks like this is your first PR to knative/serving-operator 🎉 |
|
Hi @q0115643. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@q0115643: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/check-cla |
|
This was my first PR to google opensource so I signed CLA just before writing this comment. |
|
/ok-to-test |
|
Thank @q0115643 for the contribute! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: houshengbo, q0115643 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@houshengbo sorry for the inconvenience, my profile in the commit was a bit messed up so I force-pushed a new commit with same change. |
|
/lgtm |
Proposed Changes
Release Note