Skip to content
This repository was archived by the owner on Jun 24, 2020. It is now read-only.

Remove the deprecated short name from README#346

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
rokrokss:master
Mar 12, 2020
Merged

Remove the deprecated short name from README#346
knative-prow-robot merged 1 commit into
knative:masterfrom
rokrokss:master

Conversation

@rokrokss
Copy link
Copy Markdown
Contributor

@rokrokss rokrokss commented Mar 12, 2020

Proposed Changes

Release Note

Remove the deprecated short name from README.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Welcome @q0115643! It looks like this is your first PR to knative/serving-operator 🎉

@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @q0115643. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@q0115643: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rokrokss
Copy link
Copy Markdown
Contributor Author

/check-cla

@rokrokss
Copy link
Copy Markdown
Contributor Author

rokrokss commented Mar 12, 2020

This was my first PR to google opensource so I signed CLA just before writing this comment.
I think ok-to-test is needed to retest on cla.

@houshengbo
Copy link
Copy Markdown

/ok-to-test

@houshengbo
Copy link
Copy Markdown

Thank @q0115643 for the contribute!
/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, q0115643

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Author(s) signed a CLA. and removed cla: no labels Mar 12, 2020
@rokrokss
Copy link
Copy Markdown
Contributor Author

@houshengbo sorry for the inconvenience, my profile in the commit was a bit messed up so I force-pushed a new commit with same change.

@k4leung4
Copy link
Copy Markdown
Contributor

/lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants