-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Do we need both ContainerHealthy / ResourcesAvailable conditions? #1137
Copy link
Copy link
Closed
Labels
area/APIAPI objects and controllersAPI objects and controllerskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/docSomething isn't clearSomething isn't clearkind/featureWell-understood/specified features, ready for coding.Well-understood/specified features, ready for coding.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Metadata
Metadata
Assignees
Labels
area/APIAPI objects and controllersAPI objects and controllerskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/docSomething isn't clearSomething isn't clearkind/featureWell-understood/specified features, ready for coding.Well-understood/specified features, ready for coding.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Going through #1118 I found that there is really a single point at which we determine
ContainerHealthyandResourcesAvailable, so I'm wondering whether these should be coalesced into a single condition, or whether we should continue to have distinct conditions for them.This feels related to the ongoing discussion around conditions. cc @cooperneil @sixolet @evankanderson @tcnghia