-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Clean up resource naming assumptions #1186
Copy link
Copy link
Closed
Labels
area/APIAPI objects and controllersAPI objects and controllersarea/test-and-releaseIt flags unit/e2e/conformance/perf test issues for product featuresIt flags unit/e2e/conformance/perf test issues for product featureskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Description
Metadata
Metadata
Assignees
Labels
area/APIAPI objects and controllersAPI objects and controllersarea/test-and-releaseIt flags unit/e2e/conformance/perf test issues for product featuresIt flags unit/e2e/conformance/perf test issues for product featureskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.
I keep seeing places where we're baking assumptions about sub-resource naming into the system in various ways, e.g.
revision.Name + "-deployment".These should be going through shared library methods like
controller.GetRevisionDeploymentName.