This came up in discussion on #1110. The NewController constructors have gotten (ok, always been) unwieldy. They are very mildly heterogeneous (e.g. buildInformer on revision.NewController), but have significant commonality.
This commonality actually is aligned with @mdemirhan's refactoring of controller.Base, where controller.NewBase takes the common arguments. We should consider making controller.NewBase take a new controller.Options to shrink these argument lists.
cc @evankanderson
This came up in discussion on #1110. The
NewControllerconstructors have gotten (ok, always been) unwieldy. They are very mildly heterogeneous (e.g.buildInformeronrevision.NewController), but have significant commonality.This commonality actually is aligned with @mdemirhan's refactoring of
controller.Base, wherecontroller.NewBasetakes the common arguments. We should consider makingcontroller.NewBasetake a newcontroller.Optionsto shrink these argument lists.cc @evankanderson