`Severity: Error` on successful terminal conditions seems misleading

[neosab]

At first glance, Severity: Error on Status can mislead someone into thinking that the resource failed. This is just my opinion, feel free to close this issue 😃

The following is the Status block from a successful eventing channel instance.

status:
  address:
    hostname: kafka-channel-1-channel.default.svc.cluster.local
  conditions:
  - lastTransitionTime: 2018-11-15T06:58:32Z
    severity: Error
    status: "True"
    type: Addressable
  - lastTransitionTime: 2018-11-15T06:58:32Z
    severity: Error
    status: "True"
    type: Provisioned
  - lastTransitionTime: 2018-11-15T06:58:32Z
    severity: Error
    status: "True"
    type: Ready

I think it makes sense to have it on failed terminal conditions (i.e Status: false or unknown) and failed/successful non-terminal conditions.

Again, feel free to close this issue!

[grantr]

I agree. The close proximity of Error and True when viewing the kubectl -oyaml output strongly suggests that errors have occurred. The user must be familiar with the design of the conditions API to understand that type and status are relevant and severity is irrelevant.

[prithviramesh]

/assign

[knative-prow-robot]

@prithviramesh: GitHub didn't allow me to assign the following users: prithviramesh.

Note that only knative members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[prithviramesh]

I'd like to work on this