Surface webhook failures in Revision status

[rgregg]

I tried to create a new ksvc named "3ddemo". Everything appears to work correctly, but the revision never becomes active and all the statues on the revision are "Unknown".

status:
    conditions:
    - lastTransitionTime: 2019-01-18T15:52:24Z
      status: Unknown
      type: Active
    - lastTransitionTime: 2019-01-18T15:52:25Z
      reason: Deploying
      status: Unknown
      type: ContainerHealthy
    - lastTransitionTime: 2019-01-18T15:52:25Z
      reason: Deploying
      status: Unknown
      type: Ready
    - lastTransitionTime: 2019-01-18T15:52:25Z
      reason: Deploying
      status: Unknown
      type: ResourcesAvailable

Looking through the objects, we discovered that the kubernetes service doesn't get created, because kubernetes services must start and end with an alphabetic character:

Invalid value: "3dryan-render-demo": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

However, this error doesn't get surfaced up to the revision or ksvc, and it should.

Expected Behavior

Errors that occur inside Knative should be visible to me at the revision level.

Actual Behavior

They weren't

Steps to Reproduce the Problem

1. Deploy a ksvc to a cluster that starts or ends with a number (3ddemo)

Additional Info

[vagababov]

Note, that it might end with a digit.

[vagababov]

I think this is resolved:

>k apply -f ~/kservice3.yaml
Error from server (InternalError): error when creating /usr/local/google/home/vagababov/kservice3.yaml: Internal error occurred: admission webhook webhook.serving.knative.dev denied the request: mutation failed: not a DNS 1035 label: [a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')]: metadata.name

[mattmoor]

@vagababov this is the other half of the issue: If our controllers cannot create a resource for some reason, we should surface the error message.

Today we'd just spin loop reconciling the resource continuously failing :(

[mattmoor]

/assign
I think reconciliation errors would be a good use of events. I'll take a look at how viable that is...