[Developer] Don't use glog

[broady]

Most of the samples use glog. Just use the standard log package.

https://github.com/elafros/elafros/blob/master/sample/helloworld/helloworld.go

[mattmoor]

I'm curious why?

Is it because things should work with just the standard log package? I'd buy that.

[broady]

Yep, glog is overly complicated, pollutes global flags, and is really only suitable for use internally at Google (and even then, I think the version on github is out of date compared to the internal version).

It's also not maintained (as it states in the README).

Could you please assign to me? (or give me permissions to re-assign things?)

[grantr]

FWIW Istio uses zap for logging along with a wrapper that directs glog output to zap. In addition to the points @broady mentions, zap might be a better general choice than glog because it emits structured logs that are easier for log indexers to consume (@mdemirhan might have opinions on that).

[broady]

I'd probably just go with standard library log. If people want to swap it out for their own, they can go for it. I strongly believe minimizing dependencies for example code is a good thing (particularly because it minimizes cognitive load), unless there's a very good reason to add a dependency. As you say, if elafros consumes zap log messages better than standard log, then that might be a good enough reason to add it. If not, I don't think it's worth it.

edit: another mention - it's important to separate the decisions made for elafros (zap, glog, etc) from the ones we impose/suggest to users. The tradeoffs chosen for elafros aren't obviously applicable to users.