Skip to content

Improve the error messages from our readiness probe validation #5382

@mattmoor

Description

@mattmoor

In what area(s)?

/area API

What version of Knative?

HEAD

Expected Behavior

When validating readiness probe fields, e.g. failureThreshold we should make clear that it is not wholly disallowed, but disallowed when periodSeconds is zero (and that either periodSeconds should be specified, or failureThreshold omitted).

Actual Behavior

When failureThreshold is provided without periodSeconds we state that failureThreshold is outright disallowed

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/APIAPI objects and controllerskind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions