Remove `RetryingRouteInconsistency` from all E2E tests

[markusthoemmes]

As per #1582 we technically should not need to retry our route state in E2E tests and wait for a success any more. In fact, the RetryingRouteInconsistency helper has been dumbed down to be a noop at this point.

However, currently this function provides a neat singular piece of code that can be patched downstream to still retry the relevant bits, without diluting tests too much.

I'd be forever greatful if we could hold off cleanup until at least this patch need is resolved and leaving breadcrumbs as to why it's still there here.

[shashwathi]

/assign

[markusthoemmes]

@shashwathi This issue is merely a tracking issue. As it says in the descripition, I'd really like to keep the helper in for a bit longer.

[shashwathi]

@markusthoemmes : I apologize. I read the first part of issue in hurry and assigned it.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[markusthoemmes]

/remove-lifecycle stale

This is still relevant