Support standard imagePullSecrets

[mattmoor]

In what area(s)?

/area API

Describe the feature

imagePullSecrets is a very standard way of specifying credentials for pulling container images on Kubernetes. We should expand the supported subset of PodSpec to include this, updating the specification and conformance testing to match.

cc @dgerd

[taragu]

/assign

[garron]

Should these secrets apply to the queue proxy as well, which is part of the same pod? Or is there a separate mechanism that would be used for that?

I'm actually looking into a related issue (knative/serving-operator#221) in the operator around getting the queue proxy to use imagePullSecrets, which was missed when I previously added support for imagePullSecrets for the other serving deployments.

[mattmoor]

No, I don't believe so. Also, it will also be challenging to use a single secret here because secret references are intra-namespace, so you need to copy the shared secret into every namespace with a Revision.

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[knative-housekeeping-robot]

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten