-
Notifications
You must be signed in to change notification settings - Fork 1.2k
KIngress should disallow ServiceNamespace that differs from its own #6868
Copy link
Copy link
Closed
Labels
area/networkinggood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Metadata
Metadata
Assignees
Labels
area/networkinggood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
At present the validation just checks that it is specified:
serving/pkg/apis/networking/v1alpha1/ingress_validation.go
Lines 138 to 140 in ce240ab
One of the fundamental differences between ClusterIngress and Ingress was that the former allowed this and the latter should disallow this.
I noticed this by accident playing with custom HTTP01 challenges, and we should plug this hold before someone takes a dependency on this, since it is not supported by all KIngress implementations.
/kind good-first-issue