Skip to content

Add README.md in pkg/apis/istio/v1alpha2/ #794

@akyyy

Description

@akyyy

/area API
/kind doc

Expected Behavior

We should use vendor's tool to generate Istio objects

Actual Behavior

We crafted our own version for istio types.
https://github.com/elafros/elafros/blob/c2c01208fee15326465ceddcb55174bbdb6c3192/pkg/apis/istio/v1alpha2/routerule_types.go#L34

Additional Info

From @evankanderson:
It looks like this was hand-constructed; looking at https://github.com/istio/api/blob/master/routing/v1alpha1/route_rule.pb.go#L211 (which I presume is the corresponding file, though it says "v1alpha1"), it looks like these are part of Istio.
We should have a README.md in pkg/apis/istio/v1alpha2/ explaining what's going on with these files and how they were constructed. (What was the source inspiration, why they aren't simply vendored, etc.)

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions