progressDeadlineSeconds must be configurable for Revision

[arvtiwar]

We are hardcoding the progressDeadlineSeconds for Revisions, which must be a configurable option.
https://github.com/elafros/elafros/blob/master/pkg/controller/revision/revision.go#L84

/area API
/kind dev
/assign arvtiwar

Additional Info

configuration.yaml is a good place for this configuration.

[mattmoor]

This has moved here:

serving/pkg/controller/revision/resources/constants.go

Line 43 in 8620263

var ProgressDeadlineSeconds int32 = 120

[mattmoor]

I'm inclined to close this until someone requests this.

[ryanbrainard]

I'm inclined to close this until someone requests this.

🙋‍♂️I would like to request this!

We ran into an issue with integration testing where we purposely deploy a bad image and want to get back any errors as soon as possible rather than wait out the 120 seconds. While a cluster-wide config would probably be acceptable, it would be really nice to be scoped down to a given Revision or at least to a namespace or something. Even outside of the testing realm, it seems like having this scoped would be nice since different services might have different expectations what an acceptable timeout should be.

cc: @dianadoherty, @ricardochimal

[mattmoor]

cc @dgerd

[knative-housekeeping-robot]

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

[knative-housekeeping-robot]

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten