-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Revision condition reason consolidation #880
Copy link
Copy link
Closed
Labels
area/APIAPI objects and controllersAPI objects and controllerskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureWell-understood/specified features, ready for coding.Well-understood/specified features, ready for coding.
Description
Metadata
Metadata
Assignees
Labels
area/APIAPI objects and controllersAPI objects and controllerskind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.kind/featureWell-understood/specified features, ready for coding.Well-understood/specified features, ready for coding.
/area API
/kind cleanup
/kind dev
Expected Behavior
The revision condition reasons are a set of constants, which should be defined in
https://github.com/elafros/elafros/blob/master/pkg/apis/ela/v1alpha1/revision_types.go
Actual Behavior
In https://github.com/elafros/elafros/blob/master/pkg/controller/revision/revision.go and other files, we are using strings like:
Reason: "ServiceReady"
Reason: "ProgressDeadlineExceeded"
Reason: "Inactive"
Reason: "ContainerMissing"
Reason: "Deploying"
Reason: "Activating"