Skip to content

Add the Spec fields to the service schema#10003

Closed
joshuawilson wants to merge 1 commit intoknative:mainfrom
joshuawilson:service-schema
Closed

Add the Spec fields to the service schema#10003
joshuawilson wants to merge 1 commit intoknative:mainfrom
joshuawilson:service-schema

Conversation

@joshuawilson
Copy link
Copy Markdown
Contributor

Related to #912

Proposed Changes

  • This adds the Spec section to the Template section to the Service schema.
  • I left out the Metadata section.

Release Note

Updated the Service schema to include the Spec fields.

@knative-prow-robot knative-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 31, 2020
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joshuawilson
To complete the pull request process, please assign mattmoor after the PR has been reviewed.
You can assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 31, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 31, 2020

Codecov Report

Merging #10003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10003   +/-   ##
=======================================
  Coverage   87.97%   87.97%           
=======================================
  Files         184      184           
  Lines        8657     8657           
=======================================
  Hits         7616     7616           
  Misses        793      793           
  Partials      248      248           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0eaeb8...f0f6a31. Read the comment docs.

@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2020
@markusthoemmes
Copy link
Copy Markdown
Contributor

Pingeroo, where are we on this one? :)

@joshuawilson
Copy link
Copy Markdown
Contributor Author

On hold while working other features. I'll pick it back up next.

@markusthoemmes
Copy link
Copy Markdown
Contributor

Pingeroo :). Any news @joshuawilson ?

@joshuawilson
Copy link
Copy Markdown
Contributor Author

I'm sorry, I haven't had time to get back to this.
If someone wants to take a look and see what is wrong or missing, I would be happy to get the help. I do want to get back to this, I've just been busy on other things.

@markusthoemmes
Copy link
Copy Markdown
Contributor

Optimistically closing this in favor of #11244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants