Skip to content

Add Istio RouteRule HTTPRewrite#1002

Closed
scothis wants to merge 1 commit into
knative:masterfrom
scothis:routerule-rewrite
Closed

Add Istio RouteRule HTTPRewrite#1002
scothis wants to merge 1 commit into
knative:masterfrom
scothis:routerule-rewrite

Conversation

@scothis
Copy link
Copy Markdown
Contributor

@scothis scothis commented May 31, 2018

Istio RouteRules are capable of rewriting HTTP traffic.

Refs https://istio.io/docs/reference/config/istio.routing.v1alpha1.html#HTTPRewrite

Proposed Changes

  • Add the HTTPRewrite struct to the RouteRule type.

Release Note

NONE

Istio RouteRules are capable of rewriting HTTP traffic. Adding the
HTTPRewrite struct to the RouteRule type.

Refs https://istio.io/docs/reference/config/istio.routing.v1alpha1.html#HTTPRewrite
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: scothis
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: evankanderson

Assign the PR to them by writing /assign @evankanderson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2018
@google-prow-robot
Copy link
Copy Markdown

@scothis: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-elafros-elafros-integration-tests 3ad7993 link /test pull-elafros-elafros-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@scothis scothis mentioned this pull request May 31, 2018
7 tasks
@ZhiminXiang
Copy link
Copy Markdown

Just curious, what is the use case of having HttpWrite in Elafros?

@scothis
Copy link
Copy Markdown
Contributor Author

scothis commented May 31, 2018

@ZhiminXiang working on a spike for a Stream CRD in the eventing repo. In the model, a Stream creates a k8s Service which is backed by a Broker, using RouteRules to forward traffic for the stream to the broker. The request authority is rewritten so that the broker can distinguish the stream originating the request.

https://github.com/elafros/eventing/pull/66/files#diff-f38337f075ab108b26aa2eebca7b01b5R553

Copy link
Copy Markdown
Contributor

@akyyy akyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scothis
Copy link
Copy Markdown
Contributor Author

scothis commented Jun 8, 2018

I'll pick up the capability with the istio v1alpha3 bump

@scothis scothis closed this Jun 8, 2018
@scothis scothis deleted the routerule-rewrite branch June 8, 2018 20:12
ReToCode added a commit to ReToCode/serving that referenced this pull request Nov 20, 2024
…nces/release-v1.16

Update Konflux references (release-v1.16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants