Skip to content

fix typo and redundant code#11419

Merged
knative-prow-robot merged 1 commit into
knative:mainfrom
novahe:fix/typo
May 27, 2021
Merged

fix typo and redundant code#11419
knative-prow-robot merged 1 commit into
knative:mainfrom
novahe:fix/typo

Conversation

@novahe
Copy link
Copy Markdown
Contributor

@novahe novahe commented May 26, 2021

/kind cleanup

Proposed Changes

fix typo and redundant code

Release Note

NONE

@knative-prow-robot knative-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 26, 2021
@google-cla google-cla Bot added the cla: yes Indicates the PR's author has signed the CLA. label May 26, 2021
@knative-prow-robot knative-prow-robot added area/autoscale area/networking size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

Hi @novahe. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 26, 2021
Comment thread pkg/queue/breaker_test.go
@julz
Copy link
Copy Markdown
Contributor

julz commented May 26, 2021

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2021

Codecov Report

Merging #11419 (3d10aea) into main (5d1672d) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11419      +/-   ##
==========================================
+ Coverage   87.68%   87.69%   +0.01%     
==========================================
  Files         191      191              
  Lines        9224     9224              
==========================================
+ Hits         8088     8089       +1     
  Misses        880      880              
+ Partials      256      255       -1     
Impacted Files Coverage Δ
pkg/queue/breaker.go 96.42% <ø> (ø)
pkg/reconciler/configuration/configuration.go 86.71% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d1672d...3d10aea. Read the comment docs.

Copy link
Copy Markdown
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2021
@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, NovaHe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2021
@knative-prow-robot knative-prow-robot merged commit df3b056 into knative:main May 27, 2021
@novahe novahe deleted the fix/typo branch May 27, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants