Drop the use of serving specific metric keys declared in knative.dev/pkg

[dprotaso]

Part of: knative/pkg#608

• 🧹 moves serving metric constants in knative.dev/pkg to here

[dprotaso]

/assign @skonto @evankanderson @MontyCarter

This will let us drop the serving specific metrickeys in knative.dev/pkg

[codecov]

Codecov Report

Merging #11658 (2975fe9) into main (9c2ec0f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main   #11658      +/-   ##
==========================================
+ Coverage   87.86%   87.87%   +0.01%     
==========================================
  Files         190      190              
  Lines        9253     9253              
==========================================
+ Hits         8130     8131       +1     
  Misses        874      874              
+ Partials      249      248       -1     

Impacted Files	Coverage Δ
pkg/activator/handler/metrics.go	90.90% <100.00%> (ø)
pkg/metrics/tags.go	89.28% <100.00%> (ø)
pkg/queue/request_metric.go	93.68% <100.00%> (ø)
pkg/reconciler/configuration/configuration.go	86.92% <0.00%> (+0.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2ec0f...2975fe9. Read the comment docs.

[evankanderson]

It looks like we're not changing any of the external metrics outputs here (intentionally at least), just moving constants from one place to another.

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/activator/OWNERS [dprotaso,evankanderson]
• pkg/autoscaler/OWNERS [dprotaso,evankanderson]
• pkg/metrics/OWNERS [dprotaso,evankanderson]
• pkg/queue/OWNERS [dprotaso,evankanderson]
• pkg/reconciler/autoscaling/OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment