Add conformance test for periodSeconds>0 case#11814
Merged
knative-prow-robot merged 1 commit intoknative:mainfrom Aug 19, 2021
Merged
Add conformance test for periodSeconds>0 case#11814knative-prow-robot merged 1 commit intoknative:mainfrom
knative-prow-robot merged 1 commit intoknative:mainfrom
Conversation
When periodSeconds is non-zero the QP startup optimisation is disabled and we do ignore readiness probes after startup. This causes us to continue to route to non-ready instances.
knative-prow-robot
added
size/L
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 19, 2021
nealhu
pushed a commit
to nealhu/serving
that referenced
this pull request
Aug 20, 2021
When periodSeconds is non-zero the QP startup optimisation is disabled and we do ignore readiness probes after startup. This causes us to continue to route to non-ready instances.
nealhu
pushed a commit
to nealhu/serving
that referenced
this pull request
Aug 20, 2021
When periodSeconds is non-zero the QP startup optimisation is disabled and we do ignore readiness probes after startup. This causes us to continue to route to non-ready instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When periodSeconds is non-zero the QP startup optimisation is disabled and we ignore readiness probes after startup. This causes us to continue to route to non-ready instances (see #10764)
/assign @markusthoemmes @dprotaso