Remove unused isAggressive parameter#11935
Conversation
This used to be used to determine whether to cache readiness forever after startup or not, but now it's an unused parameter. Also made isAggressive private since it's no longer used externally, and renamed it for clarity.
knative-prow-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## main #11935 +/- ##
==========================================
- Coverage 87.68% 87.64% -0.04%
==========================================
Files 197 197
Lines 9508 9521 +13
==========================================
+ Hits 8337 8345 +8
- Misses 905 909 +4
- Partials 266 267 +1
Continue to review full report at Codecov.
|
|
/lgtm |
knative-prow-robot
added
the
do-not-merge/hold
|
@psschwei guess the cluster was out of resources, let’s try retesting: /retest |
|
/retest |
|
flaky test which we disabled now in #11945 /retest |
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
|
/retest |
This used to be used to determine whether to cache readiness forever after startup or not, but now it's an unused parameter. Also made isAggressive private since it's no longer used externally, and renamed it for clarity.
3 participants
The
isAggressiveparameter in the health state server used to be used to determine whether to cache readiness forever after startup or not, but as of #11190 it's an unused parameter and the only thing that needs to know aboutperiodSeconds=0 => spam readiness checksis the prober itself.Also made
probe.IsAggressive()private since it's no longer used externally, and renamed it for clarity.