Review feedback#1225
Merged
google-prow-robot merged 7 commits intoknative:masterfrom Jun 15, 2018
Merged
Conversation
This wraps the slice literals so a single element per-line:
```
[]FooConditionType{
FooType,
BarType,
BazType,
}
```
It also inlines the literal into the `for x, y := range ...` unless it is dynamically constructed (`if foo { append }`) and needs the variable.
This changes the comparison used in the Service controller's `reconcileFoo` methods to use `equality.Semantic.DeepEqual`. Although it has slightly different semantics (stricter) I left the use of `cmp.Diff` in what we log as the difference when reconciliation is to be performed, since I think this will really help give visibility into the changes we see triggering reconciliation.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
approved
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate the review feedback from @grantr and @dprotaso on #1208