Skip to content

Use CheckEndpointState in v1beta1 domainmapping test#12373

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
nak3:use-check
Dec 2, 2021
Merged

Use CheckEndpointState in v1beta1 domainmapping test#12373
knative-prow-robot merged 1 commit intoknative:mainfrom
nak3:use-check

Conversation

@nak3
Copy link
Copy Markdown
Contributor

@nak3 nak3 commented Dec 1, 2021

This patch replaces WaitForEndpointState with CheckSuccessfulResponse in v1beta1/domain_mapping_test.go.
Other code were changed by #11680.

The same test in v1alpha1/domain_mapping_test.go uses CheckSuccessfulResponse so it should not be a problem.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 1, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 1, 2021

Codecov Report

Merging #12373 (a5618b5) into main (a6e26e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12373   +/-   ##
=======================================
  Coverage   87.37%   87.37%           
=======================================
  Files         195      195           
  Lines        9638     9638           
=======================================
  Hits         8421     8421           
  Misses        933      933           
  Partials      284      284           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281338f...a5618b5. Read the comment docs.

@nak3
Copy link
Copy Markdown
Contributor Author

nak3 commented Dec 1, 2021

/cc @shinigambit @julz @markusthoemmes

@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Dec 2, 2021

/lgtm
/approve

@knative-prow-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Dec 2, 2021

/test pull-knative-serving-istio-latest-no-mesh
/test pull-knative-serving-istio-latest-no-mesh-tls

@knative knative deleted a comment from knative-prow-robot Dec 2, 2021
@knative-prow-robot knative-prow-robot merged commit 550ef67 into knative:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants