Use CheckEndpointState in v1beta1 domainmapping test#12373
Use CheckEndpointState in v1beta1 domainmapping test#12373knative-prow-robot merged 1 commit intoknative:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12373 +/- ##
=======================================
Coverage 87.37% 87.37%
=======================================
Files 195 195
Lines 9638 9638
=======================================
Hits 8421 8421
Misses 933 933
Partials 284 284 Continue to review full report at Codecov.
|
|
/cc @shinigambit @julz @markusthoemmes |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-knative-serving-istio-latest-no-mesh |
This patch replaces
WaitForEndpointStatewithCheckSuccessfulResponsein v1beta1/domain_mapping_test.go.Other code were changed by #11680.
The same test in v1alpha1/domain_mapping_test.go uses
CheckSuccessfulResponseso it should not be a problem.