Skip to content

Updates queue container to support h2c#1257

Merged
google-prow-robot merged 1 commit intoknative:masterfrom
pivotal-cf-experimental:h2c_queue
Jun 18, 2018
Merged

Updates queue container to support h2c#1257
google-prow-robot merged 1 commit intoknative:masterfrom
pivotal-cf-experimental:h2c_queue

Conversation

@bsnchan
Copy link
Copy Markdown
Contributor

@bsnchan bsnchan commented Jun 18, 2018

Pre-req: #707, #813

Follow up from #987

Proposed Changes

  • switches to using an h2(c) server (non TLS) in the queue container

Release Note

NONE

@google-prow-robot google-prow-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 18, 2018
@google-prow-robot google-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 18, 2018
@bsnchan
Copy link
Copy Markdown
Contributor Author

bsnchan commented Jun 18, 2018

/test pull-knative-serving-integration-tests

Tests seem to have failed fetching the project name.

@bsnchan
Copy link
Copy Markdown
Contributor Author

bsnchan commented Jun 18, 2018

/assign @evankanderson

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsnchan, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2018
@google-prow-robot google-prow-robot merged commit e5f9680 into knative:master Jun 18, 2018
dsimansk pushed a commit to dsimansk/serving that referenced this pull request Apr 29, 2025
Co-authored-by: serverless-qe <serverless-support@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants