Adds sample gRPC application#1261
Conversation
* this sample depends on knative/serving#1047 to be complete
google-prow-robot
added
the
size/L
|
/assign @evankanderson |
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
/approve
Two small comments.
| flag.Parse() | ||
|
|
||
| opts := []grpc.DialOption{ | ||
| grpc.WithInsecure(), |
There was a problem hiding this comment.
Make this a flag for the future world where we have TLS sorted out for clusters with a public ingress?
|
|
||
| grpcServer := grpc.NewServer() | ||
| ping.RegisterPingServiceServer(grpcServer, pingServer) | ||
| grpcServer.Serve(lis) |
There was a problem hiding this comment.
Does grpcServer end up supporting h2c out of the box?
Might be worth a comment either documenting that it does, or mentioning that this is something that may need to be validated once #1047 is done.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bsnchan, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
* Adds comment that the sample grpc server serves h2c by default
|
/lgtm |
Co-authored-by: serverless-qe <serverless-support@redhat.com>
3 participants
Pre-req: #707, #813
Follow up from #987
Proposed Changes
Release Note