Re-enable ContainerMissing testing.#1264
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jun 19, 2018
Merged
Conversation
The testing for our ContainerMissing checking was predicating on the `Reason` at the `Configuration` level, which is unspecified. The content of the error message is also unspecified and registry specific, so this makes the check a bit more permissive (`strings.Contains` vs. `string.HasPrefix`). Fixes: knative/serving#1240
google-prow-robot
added
size/S
jessiezcc
reviewed
Jun 19, 2018
Contributor
There was a problem hiding this comment.
should we still check for Reason=="RevisionFailed" to replace ContainerMissing?
Member
Author
There was a problem hiding this comment.
I don't think we need to.
Contributor
|
/retest |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonjohnsonjr, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
creydr
pushed a commit
to creydr/knative-serving
that referenced
this pull request
Mar 25, 2025
Co-authored-by: serverless-qe <serverless-support@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing for our ContainerMissing checking was predicating on the
Reasonat theConfigurationlevel, which is unspecified. The content of the error message is also unspecified and registry specific, so this makes the check a bit more permissive (strings.Containsvs.string.HasPrefix).cc @jessiezcc
Fixes: #1240