Skip to content

Move the Configuration controller testing to use the new table-testing method. #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 4 commits into from
Jun 25, 2018
Merged

Move the Configuration controller testing to use the new table-testing method. #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1768b23
Move many of the test helper methods.
mattmoor Jun 23, 2018
98f4311
Move the Configuration controller testing to use the new table-testin…
mattmoor Jun 23, 2018
77ca982
Cleanup a leftover TODO in queueing_test.go
mattmoor Jun 23, 2018
98c0305
Add comments to obscurely named private helpers.
mattmoor Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/controller/configuration/configuration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ func (c *Controller) createRevision(config *v1alpha1.Configuration, revName stri
build := &buildv1alpha1.Build{
ObjectMeta: metav1.ObjectMeta{
Namespace: config.Namespace,
GenerateName: fmt.Sprintf("%s-", config.Name),
Name: revName,
Copy link
Copy Markdown
Contributor

@jonjohnsonjr jonjohnsonjr Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this change?

Copy link
Copy Markdown
Member Author

@mattmoor mattmoor Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the PR description / commit message:

This also changes the way we create Build names to more easily test it (mirrors what we do for Revision today).

OwnerReferences: []metav1.OwnerReference{*controllerRef},
},
Spec: *config.Spec.Build,
Expand Down
Loading