Complete the migration of the Revision controller to level-based.#1334
Merged
google-prow-robot merged 3 commits intoknative:masterfrom Jun 26, 2018
Merged
Complete the migration of the Revision controller to level-based.#1334google-prow-robot merged 3 commits intoknative:masterfrom
google-prow-robot merged 3 commits intoknative:masterfrom
Conversation
google-prow-robot
added
approved
mattmoor
changed the title
google-prow-robot
added
the
do-not-merge/work-in-progress
mattmoor
force-pushed
the
fluentd-configmap
branch
2 times, most recently
from
9840072 to
2be1073
Compare
google-prow-robot
added
size/L
mattmoor
changed the title
google-prow-robot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/assign @vaikas-google |
Member
Author
|
FYI I believe the coverage discrepancy is an exacerbation of #1331 |
Member
|
did a quick pass |
mattmoor
force-pushed
the
fluentd-configmap
branch
from
8d1bcf9 to
30f844d
Compare
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vaikas-google The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the remaining fluentd ConfigMap and autoscaler reconciliations to follow the same pattern as the rest of the Revision controller.
Fixes: #1217
WIP until #1328 is merged and this rebased. I may also try and improve the coverage of the autoscaler parts, which are in need of some TLC.