Skip to content

Conversation

@psschwei
Copy link
Member

Signed-off-by: Paul S. Schweigert paul@paulschweigert.com

Proposed Changes

Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 0.00% // Head: 86.47% // Increases project coverage by +86.47% 🎉

Coverage data is based on head (6fd608e) compared to base (6e597fa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           main   #13407       +/-   ##
=========================================
+ Coverage      0   86.47%   +86.47%     
=========================================
  Files         0      196      +196     
  Lines         0    14551    +14551     
=========================================
+ Hits          0    12583    +12583     
- Misses        0     1669     +1669     
- Partials      0      299      +299     
Impacted Files Coverage Δ
pkg/queue/request_metric.go 92.37% <0.00%> (ø)
pkg/reconciler/gc/reconciler.go 100.00% <0.00%> (ø)
pkg/autoscaler/statforwarder/statefulset.go 0.00% <0.00%> (ø)
pkg/autoscaler/config/config.go 97.72% <0.00%> (ø)
pkg/apis/serving/v1/revision_lifecycle.go 93.16% <0.00%> (ø)
pkg/metrics/tags.go 77.46% <0.00%> (ø)
pkg/autoscaler/scaling/metrics.go 96.29% <0.00%> (ø)
pkg/apis/serving/v1beta1/conversion_error.go 100.00% <0.00%> (ø)
pkg/queue/sharedmain/main.go 0.61% <0.00%> (ø)
pkg/reconciler/autoscaling/resources/metric.go 90.90% <0.00%> (ø)
... and 186 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e82287d into knative:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants