-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Don't explicitly require a service account key for autotls dns tests #13627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 86.21% // Head: 86.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #13627 +/- ##
==========================================
- Coverage 86.21% 86.19% -0.03%
==========================================
Files 197 197
Lines 14722 14722
==========================================
- Hits 12692 12689 -3
- Misses 1730 1732 +2
- Partials 300 301 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/test contour-latest |
|
|
|
/test contour-latest |
1 similar comment
|
/test contour-latest |
|
/retest |
|
ok - |
|
I pulled the patch into - #13621 |
|
the prow job is configured as follows - so maybe the presubmit-tests.sh script is broken? |
|
From the other PR
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @dprotaso @kvmware
Proposed Changes
Release Note