Skip to content

Conversation

@upodroid
Copy link
Member

@upodroid upodroid commented Jan 20, 2023

/cc @dprotaso @kvmware

Proposed Changes

Release Note

NONE

@knative-prow knative-prow bot requested review from dprotaso and krsna-m January 20, 2023 18:22
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 86.21% // Head: 86.19% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (0051e4c) compared to base (6906c92).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13627      +/-   ##
==========================================
- Coverage   86.21%   86.19%   -0.03%     
==========================================
  Files         197      197              
  Lines       14722    14722              
==========================================
- Hits        12692    12689       -3     
- Misses       1730     1732       +2     
- Partials      300      301       +1     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 82.93% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

/test contour-latest

@dprotaso
Copy link
Member

@knative-prow knative-prow bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@dprotaso
Copy link
Member

/test contour-latest

1 similar comment
@upodroid
Copy link
Member Author

/test contour-latest

@krsna-m
Copy link
Contributor

krsna-m commented Jan 20, 2023

/retest

@dprotaso
Copy link
Member

ok - contour-latest didn't run the autotls tests

@dprotaso
Copy link
Member

I pulled the patch into - #13621

@dprotaso
Copy link
Member

the prow job is configured as follows - so maybe the presubmit-tests.sh script is broken?

  - name: contour-latest
    types: [periodic]
    command:
    - runner.sh
    args:
    - ./test/presubmit-tests.sh
    - --run-test
    - ./test/e2e-tests.sh --contour-version latest
    - --run-test
    - ./test/e2e-auto-tls-tests.sh --contour-version latest --run-http01-auto-tls-tests

@dprotaso
Copy link
Member

From the other PR

Successfully set up DNS record

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@knative-prow knative-prow bot merged commit d2d5723 into knative:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants