Allow challenges for hosts that don't match the route's host

[dprotaso]

This allows certificate plugins (ie. net-cert-manager) to deal
with domain names that are really long.

Part of knative-extensions/net-certmanager#214 (comment)

Was testing it via #13621

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

Base: 86.17% // Head: 86.17% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b4c6b6c) compared to base (87f5b62).
Patch coverage: 88.23% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13637      +/-   ##
==========================================
- Coverage   86.17%   86.17%   -0.01%     
==========================================
  Files         197      197              
  Lines       14722    14727       +5     
==========================================
+ Hits        12687    12691       +4     
+ Misses       1734     1733       -1     
- Partials      301      303       +2     

Impacted Files	Coverage Δ
pkg/reconciler/route/resources/ingress.go	95.00% <85.71%> (-1.19%)	⬇️
pkg/reconciler/domainmapping/resources/ingress.go	100.00% <100.00%> (ø)
pkg/autoscaler/statserver/server.go	73.72% <0.00%> (-2.19%)	⬇️
pkg/reconciler/route/route.go	81.23% <0.00%> (+0.92%)	⬆️
pkg/autoscaler/scaling/multiscaler.go	88.59% <0.00%> (+1.34%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[KauzClay]

should there be a comment added here to explain the new return value?

[dprotaso]

What were you thinking?

[KauzClay]

I guess I was thinking something to explain what the extra domains are for. "Also returns hosts in the challenge that are not in domains". But I suppose that is just explaining the code at that point

[dprotaso]

"Also returns hosts in the challenge that are not in domains"

This function is actually all the route domains (not the HTTP01 challenge domains)

ie.
route-1.blah.example.com
route-1.blah.svc.cluster.local
route-1.blah.svc
route-1.blah

[KauzClay]

/lgtm