Skip to content

Update to Istio sidecar injection policy to avoid relying on / setting namespace level policy#1369

Closed
tcnghia wants to merge 3 commits intoknative:masterfrom
tcnghia:istio-injection-policy
Closed

Update to Istio sidecar injection policy to avoid relying on / setting namespace level policy#1369
tcnghia wants to merge 3 commits intoknative:masterfrom
tcnghia:istio-injection-policy

Conversation

@tcnghia
Copy link
Copy Markdown
Contributor

@tcnghia tcnghia commented Jun 27, 2018 •
edited
Loading

Fixes #1300 #632 #771

Proposed Changes

Applying upstream patch to istio.yaml so we can avoid explicitly setting Istio sidecar injection policy at the namespace level. We will only enable injection at the Pod level instead.

@tcnghia tcnghia requested review from mattmoor and mdemirhan June 27, 2018 15:01
@google-prow-robot google-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 27, 2018
@tcnghia tcnghia changed the title Istio injection policy Update to Istio sidecar injection policy to avoid relying on / setting namespace level policy Jun 27, 2018
mattmoor
mattmoor reviewed Jun 27, 2018
View reviewed changes
Comment thread third_party/istio-0.8.0/istio.yaml
- key: istio-injection
operator: NotIn
values:
- disabled
Copy link
Copy Markdown
Member

@mattmoor mattmoor Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this change land in an Istio release?

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jun 27, 2018

/hold

I want to send this PR for review, but I'd like to understand more about the release timeline from Istio side before checking this in.

@google-prow-robot google-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2018
@mdemirhan
Copy link
Copy Markdown
Contributor

mdemirhan commented Jun 27, 2018

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2018
@tcnghia tcnghia mentioned this pull request Jun 27, 2018
Closed
@google-prow-robot google-prow-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2018
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jun 30, 2018

This is now submitted upstream istio/istio#6704, so I am removing hold.

/hold cancel

@google-prow-robot google-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2018
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jul 2, 2018

/retest

1 similar comment
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jul 2, 2018

/retest

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jul 2, 2018

@mdemirhan I rebased so /lgtm is removed.

@mdemirhan
Copy link
Copy Markdown
Contributor

mdemirhan commented Jul 2, 2018

/lgtm
/approve

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2018
@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 2, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdemirhan, tcnghia
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mattmoor

Assign the PR to them by writing /assign @mattmoor in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jul 2, 2018

/assign @mattmoor

@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Jul 2, 2018

/hold

I'd like to understand when this will land in an Istio release before we merge it.

@google-prow-robot google-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2018
@tcnghia
Copy link
Copy Markdown
Contributor Author

tcnghia commented Jul 26, 2018

Closing since we're moving to Istio 1.0 which should already have this.

@tcnghia tcnghia closed this Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdemirhan mdemirhan Awaiting requested review from mdemirhan

1 more reviewer

@mattmoor mattmoor mattmoor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

@mdemirhan mdemirhan

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tcnghia @mdemirhan @google-prow-robot @mattmoor