Migrate config-autoscaler to use configmap.Watcher.#1417
Merged
Conversation
google-prow-robot
added
size/XXL
mdemirhan
approved these changes
Jun 29, 2018
Contributor
|
/lgtm |
Contributor
|
/test pull-knative-serving-go-coverage |
1 similar comment
Contributor
|
/test pull-knative-serving-go-coverage |
Member
Author
|
/test pull-knative-serving-integration-tests |
mattmoor
force-pushed
the
config-autoscaler
branch
from
a81c891 to
1ef1441
Compare
mattmoor
force-pushed
the
config-autoscaler
branch
from
1ef1441 to
64f3da6
Compare
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, mdemirhan, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The following is the coverage report on pkg/. Say
*TestCoverage feature is being tested, do not rely on any info here yet |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.