Skip to content

Simplify test Ready state checks#1420

Merged
google-prow-robot merged 2 commits intoknative:masterfrom
jonjohnsonjr:state-of-the-router
Jun 30, 2018
Merged

Simplify test Ready state checks#1420
google-prow-robot merged 2 commits intoknative:masterfrom
jonjohnsonjr:state-of-the-router

Conversation

@jonjohnsonjr
Copy link
Contributor

No description provided.

@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2018
@jonjohnsonjr
Copy link
Contributor Author

/assign @bobcatfish

@jonjohnsonjr
Copy link
Contributor Author

/retest

test/states.go Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can peel a level off all of these

@mattmoor
Copy link
Member

/assign @mattmoor

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2018
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonjohnsonjr, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2018
@google-prow-robot google-prow-robot merged commit 3285940 into knative:master Jun 30, 2018
@jonjohnsonjr jonjohnsonjr deleted the state-of-the-router branch June 30, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants