Skip to content

Ensure old revision stays Unreachable after Knative Service update #14287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaschaSchwarze0 wants to merge 1 commit into from
Closed

Ensure old revision stays Unreachable after Knative Service update #14287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/reconciler/autoscaling/kpa/kpa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, pa *autoscalingv1alpha1.
pa.Status.ServiceName = sks.Status.ServiceName

// If SKS is not ready — ensure we're not becoming ready.
if sks.IsReady() {
// Do not use ServerlessService.IsReady() here because this flips to not ready when the generation changes.
if sks.Status.GetCondition(nv1alpha1.ServerlessServiceConditionReady).IsTrue() {
logger.Debug("SKS is ready, marking SKS status ready")
pa.Status.MarkSKSReady()
} else {
Expand Down