Skip to content

Conversation

@knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Aug 31, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-contour.yaml contour.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-contour/latest/$x > ${GITHUB_WORKSPACE}/./third_party/contour-latest/$x
done

Details:

bumping knative.dev/net-contour 39e1bfe...2783350:
  > 2783350 Update community files (# 949)
  > 3823622 upgrade to latest dependencies (# 948)

@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from b84926c to d73ad8c Compare August 31, 2023 11:05
@knative-prow knative-prow bot requested a review from a team August 31, 2023 11:05
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/networking labels Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8f2f57b) 86.06% compared to head (7593b15) 86.06%.

❗ Current head 7593b15 differs from pull request most recent head 63f1d20. Consider uploading reports for the commit 63f1d20 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14323   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files         196      196           
  Lines       14781    14781           
=======================================
  Hits        12721    12721           
- Misses       1752     1753    +1     
+ Partials      308      307    -1     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 31, 2023
@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from d73ad8c to a9ae0a0 Compare September 1, 2023 11:05
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from a9ae0a0 to 7593b15 Compare September 4, 2023 11:05
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2023
bumping knative.dev/net-contour 39e1bfe...2783350:
  > 2783350 Update community files (# 949)
  > 3823622 upgrade to latest dependencies (# 948)

Signed-off-by: Knative Automation <automation@knative.team>
@knative-automation knative-automation force-pushed the update-nightly/net-contour branch from 7593b15 to 63f1d20 Compare September 5, 2023 11:06
Copy link
Member

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@knative-prow knative-prow bot merged commit b557307 into knative:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants