Skip to content

Conversation

@akagami-harsh
Copy link

Fixes #

Proposed Changes

  • replace deprecated sets.String with sets.Set

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Dec 26, 2023

Welcome @akagami-harsh! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 26, 2023
@knative-prow
Copy link

knative-prow bot commented Dec 26, 2023

Hi @akagami-harsh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akagami-harsh
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from ReToCode and skonto December 26, 2023 09:41
@akagami-harsh akagami-harsh changed the title Update: Replace deprecated sets.String with sets.Set Update: Replace deprecated sets.String with sets.Set from pkg/activator/net Dec 26, 2023
@ReToCode
Copy link
Contributor

ReToCode commented Jan 9, 2024

As this is depending on changes in networking and also in pkg there are more places to change this. As we need it for the close release, I did it here: #14765.

@ReToCode ReToCode closed this Jan 9, 2024
@akagami-harsh akagami-harsh deleted the fix-SA1019 branch January 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/autoscale area/networking needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants