Add a Retrying modifier for spoof.ResponseChecker#1528
Add a Retrying modifier for spoof.ResponseChecker#1528jonjohnsonjr wants to merge 5 commits intoknative:masterfrom
Conversation
google-prow-robot
added
the
size/M
jonjohnsonjr
force-pushed
the
jon/1298
branch
2 times, most recently
from
159a5c7 to
4d455e2
Compare
| @@ -74,7 +76,7 @@ func sendRequests(client spoof.Interface, domain string, num int) ([]string, err | |||
|
|
|||
| // TODO(tcnghia): The ingress endpoint tends to return 404. Ideally we can instead do: | |||
There was a problem hiding this comment.
File a bug and assign to me?
| logger, | ||
| domain, | ||
| test.EventuallyMatchesBody(autoscaleExpectedOutput), | ||
| test.Retrying(test.EventuallyMatchesBody(autoscaleExpectedOutput), http.StatusNotFound, http.StatusServiceUnavailable), |
There was a problem hiding this comment.
add comment why we allow 503 here?
There was a problem hiding this comment.
I don't know why we allow 503 here :)
There was a problem hiding this comment.
I think you can link to istio/istio#6082 and istio/istio#882 about lack of Status from Istio network programming, and may be TODO(tcnghia): remove this when istio/istio#882 is fixed?
|
/assign @bsnchan @bobcatfish |
|
/hold Wait until after we cut first release. |
google-prow-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jonjohnsonjr If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @tcnghia |
|
/retest |
|
@jonjohnsonjr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This PR is super broken, going to try again. |
6 participants
This is a strawman for the alternative to #1298 I had in mind.
Notably, this adds 503 retries to the first leg of polling in the blue/green test here:
https://github.com/jonjohnsonjr/elafros/blob/8444482c147a55e5fc3ed49166166eb9194be32c/test/conformance/blue_green_test.go#L57
I've also lost logging of retried status codes, not sure how people feel about that 😅