Skip to content

[WIP] Make (cluster-local) DNS work out of the box by default.#1609

Closed
evankanderson wants to merge 1 commit into
knative:masterfrom
evankanderson:locally-produced
Closed

[WIP] Make (cluster-local) DNS work out of the box by default.#1609
evankanderson wants to merge 1 commit into
knative:masterfrom
evankanderson:locally-produced

Conversation

@evankanderson
Copy link
Copy Markdown
Member

@evankanderson evankanderson commented Jul 17, 2018

Related to #1598

Proposed Changes

  • Change the default out-of-the-box domain to svc.cluster.local, which:
    1. Documents that the name only works locally until the cluster is further configured.
    2. Makes spec.domain be a DNS-resolvable name by default, in case we want to implement Consider having Route not become Ready until DNS resolves #1598
  • Change the k8s Service created as the public route endpoint to be an ExternalName to the knative gateway in the ingress. This makes pods launched without the istio sidecar still able to call knative. (Tested by hand.)
  • Fix a bug in managing the VirtualService where the same domain could be added to the VirtualService twice if the cluster's domain suffix were set to svc.cluster.local. This causes Istio to fail internal configuration propagation checks and route updates to not be applied.

Release Note

Change the default out-of-the-box domain to `svc.cluster.local`, to provide local no-DNS-setup installation of knative/serving.
Changes the route.ns.svc.cluster.local DNS name to point to the istio ingress to enable non-instio-injected pods to call knative.

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 17, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2018
@evankanderson
Copy link
Copy Markdown
Member Author

evankanderson commented Jul 17, 2018

/hold until after 7/30.

I wanted to capture and share this idea now, but it's probably too late given our current release stabilization effort and lack of a specific launch-blocking bug.

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Jul 17, 2018 •
edited
Loading

@evankanderson: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-serving-unit-tests 5eea634 link /test pull-knative-serving-unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tcnghia tcnghia mentioned this pull request Jul 20, 2018
Closed
@mattmoor mattmoor changed the title Make (cluster-local) DNS work out of the box by default. [WIP] Make (cluster-local) DNS work out of the box by default. Jul 21, 2018
@google-prow-robot google-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2018
@mattmoor
Copy link
Copy Markdown
Member

mattmoor commented Jul 21, 2018

@evankanderson Looks like unit tests are failing, so marking WIP for now.

@tcnghia
Copy link
Copy Markdown
Contributor

tcnghia commented Jul 25, 2018

As discussed with Evan, I'm closing this PR and will send another with more changes to dedup routes and make test passes.

@tcnghia tcnghia closed this Jul 25, 2018
@tcnghia tcnghia mentioned this pull request Jul 25, 2018
Closed
Fedosin pushed a commit to Fedosin/serving that referenced this pull request Oct 21, 2025
@nader-ziada
Fix: PodAutoscaler not reconciled due to missing class annotation (kn…
3526d22 
…ative#16141) (knative#1609)

* Fix: PodAutoscaler not reconciled due to missing class annotation race condition

setting the annotation before creating the PA eliminating the race condition

* use constant for autoscaling.knative.dev/class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

@vaikas vaikas Awaiting requested review from vaikas

Assignees

@tcnghia tcnghia

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@evankanderson @google-prow-robot @mattmoor @tcnghia