Skip to content

[wip] test ssa finalizer#16217

Closed
dprotaso wants to merge 2 commits intoknative:mainfrom
dprotaso:test-ssa-finalizer
Closed

[wip] test ssa finalizer#16217
dprotaso wants to merge 2 commits intoknative:mainfrom
dprotaso:test-ssa-finalizer

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Nov 3, 2025

testing this with - knative/pkg#3275

@knative-prow knative-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 3, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@knative-prow knative-prow Bot requested review from dsimansk, linkvt and skonto November 3, 2025 17:56
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.03%. Comparing base (7ceeaea) to head (8114073).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/domainmapping/controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16217      +/-   ##
==========================================
- Coverage   80.03%   80.03%   -0.01%     
==========================================
  Files         214      214              
  Lines       13281    13286       +5     
==========================================
+ Hits        10630    10633       +3     
- Misses       2292     2296       +4     
+ Partials      359      357       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso dprotaso changed the title test ssa finalizer [wip] test ssa finalizer Nov 3, 2025
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@dprotaso dprotaso closed this Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant