Use istio-1.0-prerelease so we are ready for 1.0 when it comes out.#1722
Merged
google-prow-robot merged 3 commits intoknative:masterfrom Jul 26, 2018
Merged
Use istio-1.0-prerelease so we are ready for 1.0 when it comes out.#1722google-prow-robot merged 3 commits intoknative:masterfrom
google-prow-robot merged 3 commits intoknative:masterfrom
Conversation
Istio 1.0 adds validation (yay!) so we need to fix a few things to make the validation happy (1) add a TLS option to our shared Gateway, and (2) make sure headers are all lowercased in VirtualServices. Also remove the 20 seconds sleep.
google-prow-robot
requested review from
adrcunha,
evankanderson,
jessiezcc,
mattmoor and
vaikas
google-prow-robot
added
the
size/XXL
Member
|
/approve This largely looks good to me. What are the changes we need to cherrypick into Defer to designated reviewers for |
google-prow-robot
added
the
approved
Contributor
Author
|
@mattmoor we need to cherry pick |
Contributor
|
/lgtm |
Contributor
|
/lgtm |
Contributor
Author
|
/assign @adrcunha Adriano can you please approve for test changes? Thanks |
ZhiminXiang
reviewed
Jul 26, 2018
| containers: | ||
| - name: istio-proxy | ||
| # PATCH #2: Add a prestop sleep. |
There was a problem hiding this comment.
Why do we not need this patch in 1.0 ?
Contributor
Author
There was a problem hiding this comment.
Good catch. I am adding that, with a TODO to remove once we fix #1370.
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor, tcnghia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
mattmoor
pushed a commit
to mattmoor/serving
that referenced
this pull request
Jul 27, 2018
…native#1722) * Use istio-1.0-prerelease so we are ready for 1.0 when it comes out. Istio 1.0 adds validation (yay!) so we need to fix a few things to make the validation happy (1) add a TLS option to our shared Gateway, and (2) make sure headers are all lowercased in VirtualServices. Also remove the 20 seconds sleep. * Fix unit tests. * Add prestop sleep, until we resolve knative#1370.
Merged
ZhiminXiang
pushed a commit
to ZhiminXiang/serving-1
that referenced
this pull request
Aug 2, 2018
…native#1722) * Use istio-1.0-prerelease so we are ready for 1.0 when it comes out. Istio 1.0 adds validation (yay!) so we need to fix a few things to make the validation happy (1) add a TLS option to our shared Gateway, and (2) make sure headers are all lowercased in VirtualServices. Also remove the 20 seconds sleep. * Fix unit tests. * Add prestop sleep, until we resolve knative#1370.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Istio 1.0 adds validation (yay!) so we need to fix a few things to make the validation happy (1) add a TLS option to our shared Gateway, and (2) make sure headers are all lowercase in VirtualServices.
Also remove the 20 second sleeps between tests.
Fix #1376 #1300
/assign @ZhiminXiang
/assign @akyyy