Skip to content

[RELEASE 0.1] Change our configurations to work with Istio 1.0 validation. #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattmoor merged 1 commit into from
Aug 3, 2018
Merged

[RELEASE 0.1] Change our configurations to work with Istio 1.0 validation. #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/202-gateway.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ spec:
protocol: HTTPS
hosts:
- "*"
tls:
mode: PASSTHROUGH
Copy link
Copy Markdown
Contributor

@vaikas vaikas Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to mean that SNI is used to route, is it always there?

Copy link
Copy Markdown
Contributor

@grantr grantr Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs for this option are scant: https://istio.io/docs/reference/config/istio.networking.v1alpha3/#Server.TLSOptions.TLSmode

I'm also curious how this value was chosen. Is it intended to have the same behavior as before?

---
# This is the Service definition for the ingress pods serving
# Knative's shared Gateway.
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/names.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ func GetServingK8SServiceNameForObj(name string) string {
}

func GetRevisionHeaderName() string {
return "Knative-Serving-Revision"
return "knative-serving-revision"
}

func GetRevisionHeaderNamespace() string {
return "Knative-Serving-Namespace"
return "knative-serving-namespace"
}
8 changes: 4 additions & 4 deletions pkg/controller/route/resources/virtual_service_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,8 @@ func TestMakeVirtualServiceRoute_VanillaScaledToZero(t *testing.T) {
Weight: 100,
}},
AppendHeaders: map[string]string{
"Knative-Serving-Revision": "revision",
"Knative-Serving-Namespace": "test-ns",
"knative-serving-revision": "revision",
"knative-serving-namespace": "test-ns",
IstioTimeoutHackHeaderKey: IstioTimeoutHackHeaderValue,
},
Timeout: DefaultActivatorTimeout,
Expand Down Expand Up @@ -360,8 +360,8 @@ func TestMakeVirtualServiceRoute_TwoInactiveTargets(t *testing.T) {
Weight: 100,
}},
AppendHeaders: map[string]string{
"Knative-Serving-Revision": "revision",
"Knative-Serving-Namespace": "test-ns",
"knative-serving-revision": "revision",
"knative-serving-namespace": "test-ns",
IstioTimeoutHackHeaderKey: IstioTimeoutHackHeaderValue,
},
Timeout: DefaultActivatorTimeout,
Expand Down