-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use Istio 1.0.0. #1771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Istio 1.0.0. #1771
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| This istio.yaml file is is generated by running | ||
| ``` | ||
| ./download-istio.sh | ||
| ``` | ||
|
|
||
| The Helm options we used are: | ||
|
|
||
| 1. `sidecarInjectorWebhook.enabled=true` & `sidecarInjectorWebhook.enableNamespacesByDefault=true`: We allow sidecar injection on all namespaces. | ||
| 2. `global.proxy.autoInject=disabled`: However, only apply sidecar injection for Pods annotated with `istio.sidecar.inject=true`, and not as a default. | ||
| 3. `prometheus.enabled=false`: Disable Prometheus by default. | ||
|
|
||
| Our goal here is to allow sidecar injection for Pods created by Knative, and | ||
| nothing else. This template is used in integration tests and also released as | ||
| an Istio-one-line-installation so that our users don't have to go through a lot | ||
| of steps to install Istio. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| # Download and unpack Istio | ||
| ISTIO_VERSION=release-1.0-20180723-09-15 | ||
| DOWNLOAD_URL=https://storage.googleapis.com/istio-prerelease/daily-build/${ISTIO_VERSION}/istio-${ISTIO_VERSION}-linux.tar.gz | ||
| ISTIO_VERSION=1.0.0 | ||
| DOWNLOAD_URL=https://github.com/istio/istio/releases/download/${ISTIO_VERSION}/istio-${ISTIO_VERSION}-linux.tar.gz | ||
|
|
||
| wget $DOWNLOAD_URL | ||
| tar xzf istio-${ISTIO_VERSION}-linux.tar.gz | ||
| cd istio-${ISTIO_VERSION} | ||
|
|
@@ -9,7 +10,6 @@ cd istio-${ISTIO_VERSION} | |
| helm template --namespace=istio-system \ | ||
| --set sidecarInjectorWebhook.enabled=true \ | ||
| --set sidecarInjectorWebhook.enableNamespacesByDefault=true \ | ||
| --set global.proxy.image=proxyv2 \ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just curious, why do we not need to set "global.proxy.image=proxyv2" ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The PR is updated with the explanation #1771 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good to know. Thanks! |
||
| --set global.proxy.autoInject=disabled \ | ||
| --set prometheus.enabled=false \ | ||
| install/kubernetes/helm/istio > ../istio.yaml | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to make note of whether Istio installed as configured here is a production-ready configuration or more of a "kick-the-tires" configuration. I honestly do not know, but it would be good to call it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is non-blocking, btw.