Skip to content

No need to pass a build name around when reconciling a configuration#1793

Merged
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:config-reconcile-helper-clean-up
Aug 7, 2018
Merged

No need to pass a build name around when reconciling a configuration#1793
knative-prow-robot merged 1 commit into
knative:masterfrom
dprotaso:config-reconcile-helper-clean-up

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Aug 3, 2018

No description provided.

@google-prow-robot
Copy link
Copy Markdown

google-prow-robot commented Aug 3, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dprotaso
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tcnghia

If they are not already assigned, you can assign the PR to them by writing /assign @tcnghia in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 3, 2018
@dprotaso dprotaso mentioned this pull request Aug 3, 2018
Closed
@knative-metrics-robot
Copy link
Copy Markdown

knative-metrics-robot commented Aug 3, 2018

The following is the coverage report on pkg/.
Say /test pull-knative-serving-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/reconciler/v1alpha1/configuration/resources/revision.go Do not exist 100.0%
pkg/reconciler/v1alpha1/configuration/configuration.go Do not exist 93.8%

@dprotaso
Copy link
Copy Markdown
Member Author

dprotaso commented Aug 4, 2018

/assign @mattmoor

mattmoor
mattmoor approved these changes Aug 7, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2018
@knative-prow-robot
Copy link
Copy Markdown
Contributor

knative-prow-robot commented Aug 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mattmoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2018
@knative-prow-robot knative-prow-robot merged commit b0d8503 into knative:master Aug 7, 2018
@dprotaso dprotaso deleted the config-reconcile-helper-clean-up branch September 11, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grantr grantr Awaiting requested review from grantr

1 more reviewer

@mattmoor mattmoor mattmoor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattmoor mattmoor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dprotaso @google-prow-robot @knative-metrics-robot @knative-prow-robot @mattmoor