Use the correct signature for example test #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example tests don't get the testing object. Using log.Fatal is equivalent to t.Error because it will cause output comparison to fail.
bobcatfish
approved these changes
Feb 21, 2018
Contributor
bobcatfish
left a comment
bobcatfish
left a comment
There was a problem hiding this comment.
Thanks for fixing this @grantr !
Contributor
|
Thanks, Grant. You fixed this way faster than me, now I have one less blocker for the go tests. :) |
Contributor
|
@grantr @mattmoor I created this issue in the bazel rules_go repo: bazel-contrib/rules_go#1341 |
nak3
pushed a commit
to nak3/serving
that referenced
this pull request
Jul 31, 2019
Update the catalogsource for the newest image.
ReToCode
pushed a commit
to ReToCode/serving
that referenced
this pull request
Mar 31, 2023
* Add github action for the validation * Fix error message * Some clean up * Add version label accurately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example tests don't get the testing object, so the signature is empty and they can't use
t.Error. This PR replaces that withlog.Fatal, which is equivalent because it will cause output comparison to fail if it prints anything.@mattmoor: @bobcatfish discovered that Bazel's
go_testrule doesn't run example tests, which is why this stayed broken for so long. See #193 (comment).