Minor nits in update-codegen.sh#2028
Conversation
knative-prow-robot
added
the
size/S
|
/assign @adrcunha |
| set -o nounset | ||
| set -o pipefail | ||
|
|
||
| if [ -z "${GOPATH:-}" ]; then |
There was a problem hiding this comment.
This is nice. We should move this to library.sh, so all scripts will benefit from it.
| --go-header-file ${REPO_ROOT_DIR}/hack/boilerplate/boilerplate.go.txt | ||
|
|
||
| # Depends on generate-groups.sh to install bin/deepcopy-gen | ||
| ${GOPATH}/bin/deepcopy-gen --input-dirs \ |
There was a problem hiding this comment.
I wonder if update-codegen.sh and verify-codegen.sh should be helper scripts in test-infra, so all repos can benefit from updates like this.
There was a problem hiding this comment.
Would test-infra repo vendor the dependencies?
There was a problem hiding this comment.
No, I was thinking in something simpler, just the logic in this script.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
3 participants
MInor nits in
hack/update-codegen.shPulling from: #2009